Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed test_write_report() log path issue #954

Merged
merged 3 commits into from
Apr 11, 2022
Merged

Fixed test_write_report() log path issue #954

merged 3 commits into from
Apr 11, 2022

Conversation

TheChymera
Copy link
Contributor

@TheChymera TheChymera commented Apr 7, 2022 •
edited by jwodder
Loading

Closes #948

Fix for another function is ongoing, hopefully done within the hour.

@codecov
Copy link

codecov bot commented Apr 7, 2022 •
edited
Loading

Codecov Report

Merging #954 (5a577ee) into master (0dec77e) will decrease coverage by 0.01%.
The diff coverage is 88.88%.

@@            Coverage Diff             @@
##           master     #954      +/-   ##
==========================================
- Coverage   87.34%   87.33%   -0.02%     
==========================================
  Files          65       65              
  Lines        8085     8099      +14     
==========================================
+ Hits         7062     7073      +11     
- Misses       1023     1026       +3
Flag Coverage Δ
unittests 87.33% <88.88%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandi/validate.py 100.00% <ø> (ø)
dandi/cli/cmd_validate.py 80.76% <60.00%> (-2.57%) ⬇️
dandi/bids_validator_xs.py 85.55% <100.00%> (+0.42%) ⬆️
dandi/tests/test_bids_validator_xs.py 100.00% <100.00%> (ø)
dandi/support/threaded_walk.py 92.85% <0.00%> (-1.79%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0dec77e...5a577ee. Read the comment docs.

@yarikoptic
Copy link
Member

Please rebase on current master, there was a fix to stalling.

@TheChymera
Copy link
Contributor Author

Hi @jwodder — I understand this is somewhat urgent and @yarikoptic might not be with us next week. Can you have a look at this and let me know if it's ok to merge even with the slight test coverage decrease? The log files get dropped either under pytest's tmp_path or under /var/tmp/ which is now the default location if logging is desired but a path not specified by the user.

@yarikoptic yarikoptic requested a review from jwodder April 10, 2022 17:35
@jwodder jwodder added the tests Add or improve existing tests label Apr 11, 2022
@jwodder jwodder merged commit b08cae0 into master Apr 11, 2022
@jwodder jwodder deleted the fixtests branch April 11, 2022 13:13
@github-actions
Copy link

🚀 PR was released in 0.39.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yarikoptic yarikoptic yarikoptic left review comments

@jwodder jwodder jwodder approved these changes

Assignees
No one assigned
Labels
released tests Add or improve existing tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BIDS validator tests create bids-validator-report_*.log files in repository root
3 participants
@TheChymera @yarikoptic @jwodder